Skip to content

ENH: Add public types to the package. #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobiasraabe opened this issue Dec 13, 2021 · 2 comments · Fixed by #197
Closed

ENH: Add public types to the package. #166

tobiasraabe opened this issue Dec 13, 2021 · 2 comments · Fixed by #197
Labels
enhancement New feature or request
Milestone

Comments

@tobiasraabe
Copy link
Member

Is your feature request related to a problem?

#160 added rudimentary typing to the package.

What is still missing are public types which can be used in plugins and other code to validate functions.

Describe the solution you'd like

Add types to the public interface. Here is a list of published types:

Additional context

  • https://github.com/pytest-dev/pytest/issues/7469 is the main issue describing typing in pytest.
@tobiasraabe tobiasraabe added the enhancement New feature or request label Dec 13, 2021
@tobiasraabe
Copy link
Member Author

For a first shot, try to type https://github.com/tobiasraabe/software_patents and see what issues come up.

@tobiasraabe
Copy link
Member Author

It would be super cool if we could enforce that all hook implementations follow the types of the hook specifications. Here are some hints how to accomplish it:

@tobiasraabe tobiasraabe modified the milestones: v0.2.0, v0.1.9 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant