Skip to content

Enable rendering of exceptions and tracebacks raised in subprocesses. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 20, 2021

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jul 18, 2021

Closes #126.

@tobiasraabe tobiasraabe added this to the v0.1.0 milestone Jul 18, 2021
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #130 (5239a8a) into main (21b98fb) will decrease coverage by 25.69%.
The diff coverage is 73.91%.

❗ Current head 5239a8a differs from pull request most recent head dee85f1. Consider uploading reports for the commit dee85f1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #130       +/-   ##
===========================================
- Coverage   93.28%   67.58%   -25.70%     
===========================================
  Files          67       67               
  Lines        5598     5606        +8     
===========================================
- Hits         5222     3789     -1433     
- Misses        376     1817     +1441     
Flag Coverage Δ
end_to_end ?
integration ?
unit 67.58% <73.91%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/clean.py 38.28% <33.33%> (-53.91%) ⬇️
src/_pytask/debugging.py 29.87% <50.00%> (ø)
src/_pytask/profile.py 46.38% <50.00%> (-40.37%) ⬇️
src/_pytask/resolve_dependencies.py 79.54% <66.66%> (-20.46%) ⬇️
src/_pytask/traceback.py 94.11% <90.00%> (-5.89%) ⬇️
src/_pytask/collect.py 78.22% <100.00%> (-15.33%) ⬇️
src/_pytask/execute.py 86.02% <100.00%> (-11.77%) ⬇️
tests/test_collect_command.py 24.09% <0.00%> (-75.91%) ⬇️
tests/test_clean.py 30.68% <0.00%> (-69.32%) ⬇️
tests/test_debugging.py 31.43% <0.00%> (-67.81%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b98fb...dee85f1. Read the comment docs.

@tobiasraabe tobiasraabe changed the base branch from main to tracebackhide July 18, 2021 21:03
Base automatically changed from tracebackhide to main July 18, 2021 21:51
@tobiasraabe tobiasraabe merged commit 9b1d7ce into main Jul 20, 2021
@tobiasraabe tobiasraabe deleted the show-tracebacks-for-parallel branch July 20, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Shortening of tracebacks is too aggressive.
1 participant