Skip to content

Add typing. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2022
Merged

Add typing. #18

merged 10 commits into from
Apr 16, 2022

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Feb 7, 2022

Changes

Add typing to the package.

Blocked by pytask-dev/pytask#197.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

@tobiasraabe tobiasraabe added this to the v0.2.0 milestone Mar 10, 2022
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #18 (fcbecfa) into main (6f2a3d2) will increase coverage by 1.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   62.28%   63.31%   +1.02%     
==========================================
  Files          15       15              
  Lines         472      477       +5     
==========================================
+ Hits          294      302       +8     
+ Misses        178      175       -3     
Flag Coverage Δ
end_to_end 58.28% <100.00%> (+1.07%) ⬆️
unit 52.83% <95.23%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytask_stata/collect.py 88.33% <100.00%> (+0.61%) ⬆️
src/pytask_stata/config.py 89.18% <100.00%> (ø)
src/pytask_stata/execute.py 51.72% <100.00%> (+3.57%) ⬆️
src/pytask_stata/parametrize.py 100.00% <100.00%> (+37.50%) ⬆️
src/pytask_stata/plugin.py 100.00% <100.00%> (ø)
src/pytask_stata/shared.py 83.33% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2a3d2...fcbecfa. Read the comment docs.

@tobiasraabe tobiasraabe merged commit e197932 into main Apr 16, 2022
@tobiasraabe tobiasraabe deleted the typing branch April 16, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant