Skip to content

Small fixes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Small fixes #33

merged 2 commits into from
Feb 4, 2023

Conversation

hmgaudecker
Copy link
Contributor

Noted a couple of things while working on OpenSourceEconomics/econ-project-templates#131

  • Unsafe link
  • I believe that GHA=y and codecov=n would have led to error in GHA because the workflow file is copied without rendering. Just assume codecov to be Y unless GHA not desired, all other fixes do not seem worth the cost to me.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #33 (a06acc5) into main (df3c15e) will not change coverage.
The diff coverage is n/a.

❗ Current head a06acc5 differs from pull request most recent head db7534e. Consider uploading reports for the commit db7534e to get more accurate results

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   79.34%   79.34%           
=======================================
  Files           4        4           
  Lines          92       92           
=======================================
  Hits           73       73           
  Misses         19       19           
Flag Coverage Δ
end_to_end 79.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tobiasraabe tobiasraabe added this to the v1.5.0 milestone Jan 26, 2023
@tobiasraabe tobiasraabe merged commit f8c7ea3 into main Feb 4, 2023
@tobiasraabe tobiasraabe deleted the small_fixes branch February 4, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants