Don't allow users with unverified emails to upload at all #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dstufft
force-pushed
the
limit-unverified
branch
from
c68578e to
6d0e1c4
Compare
dstufft
force-pushed
the
limit-unverified
branch
from
6d0e1c4 to
31a8715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will further expand the actions that a user without a verified email address cannot do, to uploading any file at all. Since this is the primary thing that people tend to do with PyPI (at least for the people for whom having a user account is very important), this should act as a strong forcing function to get people to verify their email address.
This does take a stronger stance that the old code did, instead of simply allowing any verified email, it explicitly checks to see if the primary email address is verified. The primary email address is the only one that we are going to attempt to send emails to, so it is the most important one to ensure remains valid.
This further progresses #3632.