Skip to content

Fix ZIP bomb threshold too low #13967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Fix ZIP bomb threshold too low #13967

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2216d3e
Fix ZIP bomb threshold too low
miohtama Jun 20, 2023
cb2d9b7
Update legacy.py
miohtama Jun 20, 2023
373513c
Update warehouse/forklift/legacy.py
ewdurbin Jun 21, 2023
794d34d
Merge branch 'main' into patch-2
ewdurbin Jun 21, 2023
3872c36
lints and stuff
ewdurbin Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion warehouse/forklift/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@
PATH_HASHER = "blake2_256"

COMPRESSION_RATIO_MIN_SIZE = 64 * ONE_MB
COMPRESSION_RATIO_THRESHOLD = 10

# If the zip file decompressed to 50x more space
# than it is uncompressed, consider it a ZIP bomb.
# Note that packages containing interface descriptions, JSON,
# such resources can compress really well.
# See discussion here: https://github.com/pypi/warehouse/issues/13962
COMPRESSION_RATIO_THRESHOLD = 50


# Wheel platform checking
Expand Down