refactor: replace URLType with Text #13899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying datatype for URLType is `Text` and we don't use any of the functionality from the type at all. Introduced in pypi#9512 We don't need to carry the library any further. Signed-off-by: Mike Fiedler <[email protected]>
miketheman
changed the title
ewdurbin
approved these changes
Jun 9, 2023
|
@miketheman I fought the dependency fight so you don't have to: #13861 |
Thanks! I reviewed that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying datatype for URLType is
Textand we don't use any of the functionality from the type at all.Introduced in #9512
We don't need to carry the library any further.