Removed support for the 'legacy-editable' feature. #4953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [the docs](https://github.com/pypa/setuptools/blob/8e4868a036b7fae3208d16cb4e5fe6d63c3752df/docs/userguide/development_mode.rst#legacy-behavior), pip no longer relies on this feature and it's been there for over two years.
|
My rationale for rolling this out prior to #2908 is that I'd like to ensure that it doesn't cause too much disruption and need to be rolled back. |
CheckmkCI
pushed a commit
to Checkmk/checkmk
that referenced
this pull request
Apr 23, 2025
Tackles pylint issues in form of
No name 'SiteId' in module 'livestatus'
and
mypy issues in form of
error: Cannot find implementation or library stub for module named "cmk.agent_based.v2"
This change restricts setuptools to v<79 to avoid new behavior
regarding legacy "editable installs"
(see pypa/setuptools#4953) which resulted in
mypy and pylint not being able to find the external packages in our
packages / folder.
Possible permanent fix, see https://github.com/pypa/setuptools/blob/main/docs/userguide/development_mode.rst#legacy-behavior
CMK-23122
Change-Id: I45dc35de4ed9b824a2fef8fe9076d8d72ce7b60e
dwpaley
added a commit
to cctbx/cctbx_project
that referenced
this pull request
May 1, 2025
Legacy-editable mode was removed in pypa/setuptools#4953, this env variable no longer does anything. We accommodate the new behavior in cctbx/dxtbx#807 and dials/dials#2906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs, pip no longer relies on this feature and that notice has been there for over two years.
Removal of this feature is required to eliminate reliance on the
developcommand, which is required to eliminate reliance on theeasy_installcommand (#917).Summary of changes
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)