Skip to content

Conversation

@matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jan 11, 2023

Summary of changes

The first instance of LDFLAGS is removed instead of the second to match the ordering style of the preceding environment variables (CC, CPP, CXX, LDSHARED). This repeat was introduced in PR #3368 in what seems like a very easy to make copy and paste typo.

Pull Request Checklist

  • [N/A] Changes have tests
  • [N/A] News fragment added in changelog.d/.
    (See documentation for details) (Skipping this as I don't think you want typo corrections in the CHANGELOG, but I can add if desired.)

* The first instance of LDFLAGS is removed instead of the second
  to match the style of the preceding environment variables.
@matthewfeickert
Copy link
Contributor Author

This is ready for review.

@abravalheri abravalheri merged commit 583836f into pypa:main Jan 12, 2023
@matthewfeickert matthewfeickert deleted the docs/remove-extra-LDFLAGS branch January 12, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants