PEP 621 added #293
Merged
PEP 621 added #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apurvakhatri <[email protected]>
di
reviewed
Aug 23, 2023
Signed-off-by: apurvakhatri <[email protected]>
di
reviewed
Aug 24, 2023
Signed-off-by: apurvakhatri <[email protected]>
miketheman
requested changes
Aug 25, 2023
added 2 commits
August 25, 2023 19:21
Signed-off-by: apurvakhatri <[email protected]>
Signed-off-by: apurvakhatri <[email protected]>
miketheman
requested changes
Aug 26, 2023
added 2 commits
August 26, 2023 23:29
Signed-off-by: apurvakhatri <[email protected]>
Signed-off-by: apurvakhatri <[email protected]>
miketheman
requested changes
Aug 28, 2023
Signed-off-by: apurvakhatri <[email protected]>
miketheman
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
I'm good with these changes.
@di care to take another pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #284
Describe your changes
Read PEP 621 Documentation and migrated metadata from setup.py to pyproject.toml.
project table contains the static fields whereas version and classifiers are added dynamic fields as per PEP 621.
Testing performed
python3 setup.py bdist and twine check dist/ ran successfully.
OS: MacOS 13.3.1
Additional context
.toml does not support reusing of variables (toml-lang/toml#829) therefore it was difficult to migrate copyright, which uses author.