[RFC] vcs/pip : Remove warning when cloning from a reference

[rousseldenis]

What's the problem this feature will solve?

Nowadays, in project oriented developments, it is quite common wanting to install packages from temporary sources (e.g.: an open Pull Request).

Currently, that installation mode displays a warning caused by :

pip/src/pip/_internal/vcs/git.py

Line 228 in 0827d76

"Did not find branch or tag '%s', assuming revision or ref.",

Describe the solution you'd like

Change the logger level to INFO.

Alternative Solutions

None

Additional context

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[pfmoore]

IMO this warning is correct and should remain. Yes, what you are doing is acceptable, but it has risks, as the URL doesn't point to a stable version of the source. As a result, warning of the issue is the right thing to do - the user can review the warning and ignore it if they understand the risk and are happy with it.

[rousseldenis]

Of course, I have this warning for years and I don't look at it too much.

But, this contributes in logs noise. The fact that writing the url with that particular notation makes people aware of what they are doing before having the warning.

So, here came my thoughts about that change and how it can a little smooths developments.

[sbidoul]

This warning has always been mysterious to me too.

IMO this warning is correct and should remain. Yes, what you are doing is acceptable, but it has risks, as the URL doesn't point to a stable version of the source. As a result, warning of the issue is the right thing to do - the user can review the warning and ignore it if they understand the risk and are happy with it.

Actually, the warning only happens when installing from a git ref (such a GitHub PR) or a partial sha. When installing from a branch (that is mutable), a tag (that is also mutable) or a full commit sha (that is immutable), we don't show any warning.

So it does not seem this warning is useful as an indicator of the stability of the source.

I'd be inclined to remove it completely.

[pfmoore]

OK, I misunderstood the warning. I'll happily defer to your judgement here.

[ichard26]

The associated PR has been merged (am on mobile so can't easily link it).