Lazily evaluate markers to mitigate non-PEP 440 version errors #834
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardpeek-crown-public
force-pushed
the
issue-774-mitigation-by-lazy-eval
branch
from
9167919 to
e48ea29
Compare
edwardpeek-crown-public
force-pushed
the
issue-774-mitigation-by-lazy-eval
branch
from
149b776 to
8a82eb2
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
There's also #877 trying to solve the same problem. |
Contributor
|
Closing since #939 was accepted and will be in the RC (coming soon). Please test and reopen if consideration on this still is needed. Combined with other changes, hopefully this all works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigation for #774.
Some packages define markers in an order where short-circuiting the "and" expressions can skip the problematic version comparisons.
This PR changes the marker evaluation to be lazy so that the marker expressions not affecting the outcome are not evaluated.