Extract glob specification to a separated document and add reference implementation #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
befeleme
approved these changes
Mar 14, 2025
cdce8p
approved these changes
Mar 14, 2025
chrysle
approved these changes
Mar 15, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on the discussion in python/peps#4299.
I basically extracted the existing text, but tried to make it slightly more generic so that it is not tied to
license-filesand can be reused somewhere else. Then I added a reference implementation based on @cdce8p's contribution to Setuptools.It seems that other PEPs in writing are looking into using the same glob definition, so that would also be a good reason for the extraction.
Closes python/peps#4299
/cc @befeleme
📚 Documentation preview 📚: https://python-packaging-user-guide--1826.org.readthedocs.build/en/1826/