-
Notifications
You must be signed in to change notification settings - Fork 235
Including manylinux2010 in readme #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96b4d42 to
4f42ffe
Compare
|
@armudgal, I agree that |
|
Sure thanks. I will make the required changes. |
|
Speaking of which, can someone with admin superpowers (maybe @njsmith) make the manylinux1 a GitHub protected branch, so that no one can push to it directly, but need to make PRs that must be reviewed and so on? |
|
One bottleneck for this PR would be to merge pypa/python-manylinux-demo#19 first, so that the demo is on the same page with this repository. |
mayeut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comment still applies on the newer commit.
PEP 571 also defines the manylinux2010_i686 platform tag even though we don't have an image for this (yet).
It should read:
This was further enhanced by `PEP 571 <https://www.python.org/dev/peps/pep-0571/>`_
defining ``manylinux2010_x86_64`` and ``manylinux2010_i686`` platform tags.
|
@armudgal, |
|
@armudgal, your commit mentions |
- Adding i686 tag in the readme - Updating PEP number in Docker image content
|
I did not stage that file by mistake. Apologies 🙉 |
|
LGTM thanks. |
Hi there,
As mentioned in #179.
I am not sure as
manylinux2010will be replacingmanylinux1or we still want to mentionmanylinux1in the readme.According to me:
README should majorly talk about
manylinux2010and includemanylinux1brieflybut since
manylinux2010is in demo phase, would that be a good idea?Looking for opinions and suggestions.
Thanks
PS: Did a blunder in commit message, fixing it