feat: add test-in-source #2419
Closed
feat: add test-in-source #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/test-in-source
branch
from
1cb772b to
bcb597c
Compare
I've responded on the upstream ticket - but tl;dr - placeholders would be very difficult to accomodate in iOS, as the build machine doesn't have good knowledge of the locations on the simulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2406, this is a proposed solution providing a cibuildwheel 2.x default, but an opt-in to the new behavior. It is required (currently) to opt-in for iOS support.
{wheel}placeholder was missing on pyodide, added.Currently, all this happens after
before-test, but I think it should be set up beforebefore-test, so thatbefore-testgets accurate placeholders.@freakboy3742, am I right in deducing that all placeholders are unsupported on iOS? Is there a reason we can't fill them in with the iOS paths? If we did, then we could support "out of path" runs, I think; like linux, both would be available on the simulator? Or would that not work for some reason? From what I remember paths are allowed on iOS as long as you have permission to the location they point at.