Skip to content

Asyncio future removed from sync client. #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
Dec 20, 2024
Merged

Asyncio future removed from sync client. #2514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymodbus/transaction/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def __init__(
else:
self._lock = asyncio.Lock()
self.low_level_send = self.send
self.response_future: asyncio.Future = asyncio.Future()
self.response_future: asyncio.Future = asyncio.Future()

def dummy_trace_packet(self, sending: bool, data: bytes) -> bytes:
"""Do dummy trace."""
Expand Down Expand Up @@ -161,8 +161,8 @@ async def server_execute(self) -> tuple[ModbusPDU, int, Exception]:
Used in server, with an instance for each connection, therefore
there are NO concurrency.
"""
pdu, addr, exc = await asyncio.wait_for(self.response_future, None)
self.response_future = asyncio.Future()
pdu, addr, exc = await asyncio.wait_for(self.response_future, None)
return pdu, addr, exc

def pdu_send(self, pdu: ModbusPDU, addr: tuple | None = None) -> None:
Expand Down