Improve type of parameter values of write_registers #2411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neous lists of type list[int] or list[bytes] we promote the type of values from list to Sequence (see Issue pymodbus-dev#2368)
Collaborator
|
FYI, in the main directory you will find check_ci.sh a small utility that runs like CI, but locally and thereby allow ruff and others to automatically change the code, instead of just suggesting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use write_registers type correctly with inhomogeneous lists of type list[int] or list[bytes] as values, we promote the type of the parameter values from list to Sequence (see Issue #2368)