Skip to content

Update dev dependencies #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiversen merged 2 commits into from
Jul 19, 2024
Merged

Update dev dependencies #2241

janiversen merged 2 commits into from
Jul 19, 2024

Conversation

@jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Jul 18, 2024

No description provided.

@jameshilliard jameshilliard mentioned this pull request Jul 18, 2024
Closed
janiversen
janiversen requested changes Jul 18, 2024
View reviewed changes
.github/workflows/ci.yml
if: matrix.run_lint == true
run: |
ruff .
ruff check .
Copy link
Collaborator

@janiversen janiversen Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a mixture of CI and version bumps, as written earlier:

  • CI changes are in seperate PR
  • version bumps are in a seperate PR.

This is done for several reasons:

  • mixed changes are harder to bisect
  • version bumps need to be clearly identifiable in the changelog for users
  • CI changes and version bumps needs extra handling in github actions

Copy link
Contributor Author

@jameshilliard jameshilliard Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the CI change out to #2242.

Copy link
Collaborator

@janiversen janiversen Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still contains the CI part.

Copy link
Contributor Author

@jameshilliard jameshilliard Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it from this one(although tests fail again without that).

Copy link
Collaborator

@janiversen janiversen Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should not be affected by the 3rd party version numbers, but I will ask CI to run on this PR (due to CI setup it is more than just starting CI).

janiversen
janiversen approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@janiversen janiversen merged commit 3dea7ac into pymodbus-dev:dev Jul 19, 2024
@alexrudd2
Copy link
Collaborator

alexrudd2 commented Jul 19, 2024

The change from ruff . to ruff check . is not a change in CI functionality, it's a required migration for Ruff 0.5.0.

See documentation of the change here: https://astral.sh/blog/ruff-v0.5.0#removed-deprecated-features

@jameshilliard jameshilliard deleted the update-dev-deps branch July 19, 2024 18:48
@janiversen
Copy link
Collaborator

janiversen commented Jul 19, 2024

@alexrudd2 I agree, I read the same, but nonetheless CI changes are in a separate CI, which are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameshilliard @alexrudd2 @janiversen