on_reconnect_callback removed, on_connect_callback added. #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
force-pushed
the
on_reconnect
branch
from
73be798 to
f047a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_reconnect_callback connected the app directly with the transport layer and caused problems.
It was not implemented in the sync client.
Added new parameter: on_connect_callback()
For async clients on_connect_callback(True) is called when client is connected, and on_connect_callback(False) is called when client is disconnected.
Remark, the disconnected call, does NOT replace the reconnect mechanism, but is merely meant as an informative call.