Skip to content

Cleanup author/maintainer fields #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrudd2 merged 2 commits into from
Oct 17, 2023
Merged

Cleanup author/maintainer fields #1833

alexrudd2 merged 2 commits into from
Oct 17, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Oct 17, 2023

The TOML with overlapping is quotes apparently valid, but confusing (and it crashes the TOML parser on Python.38/windows

authors = [{name = '"Galen Collins'}, {name = 'Jan Iversen"'}]
maintainers = [{name = '"dhoomakethu'}, {name = 'janiversen"'}]
pip._vendor.toml.decoder.TomlDecodeError: Found tokens after a closed string. Invalid TOML. (line 9 column 1 char 174)

janiversen
janiversen approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alexrudd2 alexrudd2 merged commit ab9b41b into dev Oct 17, 2023
@alexrudd2 alexrudd2 deleted the you-say-tomato-i-say-toml branch October 17, 2023 18:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrudd2 @janiversen