Skip to content

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented May 31, 2023

Closes #1558

(I'm assuming essentially all callers will use str instead of bytes)

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@janiversen janiversen merged commit 448a2a8 into dev May 31, 2023
@alexrudd2 alexrudd2 deleted the make-byte-string branch May 31, 2023 13:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary python2->3 code can likely be removed

3 participants