Skip to content

Don't catch KeyboardInterrupt twice for REPL server #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiversen merged 1 commit into from
Apr 18, 2023
Merged

Don't catch KeyboardInterrupt twice for REPL server #1498

janiversen merged 1 commit into from
Apr 18, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Apr 18, 2023

Closes #1497

New behaviour:

❯ pymodbus.server run --modbus-server tcp --framer socket --slave-id 1 --slave-id 4 --random 2

__________                          .______.                    _________
\______   \___.__. _____   ____   __| _/\_ |__  __ __  ______  /   _____/ ______________  __ ___________
 |     ___<   |  |/     \ /  _ \ / __ |  | __ \|  |  \/  ___/  \_____  \_/ __ \_  __ \  \/ // __ \_  __ \\
 |    |    \___  |  Y Y  (  <_> ) /_/ |  | \_\ \  |  /\___ \   /        \  ___/|  | \/\   /\  ___/|  | \/
 |____|    / ____|__|_|  /\____/\____ |  |___  /____//____  > /_______  /\___  >__|    \_/  \___  >__|
           \/          \/            \/      \/           \/          \/     \/                 \/


SERVER > exit
Bye Bye!!!

@alexrudd2 alexrudd2 requested a review from dhoomakethu April 18, 2023 05:18
@alexrudd2
Copy link
Collaborator Author

alexrudd2 commented Apr 18, 2023

Also, the REPL client catches CTRL+C and CTRL+D.
CTRL+D exits the entire client.
CTRL+C only exits the current command.

The server has no such difference.

(this PR doesn't change anything)

janiversen
janiversen approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@janiversen janiversen merged commit d6dce90 into dev Apr 18, 2023
@janiversen janiversen deleted the repl-server-exit branch April 18, 2023 06:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

@dhoomakethu dhoomakethu Awaiting requested review from dhoomakethu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REPL server needs CTRL+C twice to exit

3 participants

@alexrudd2 @janiversen