Skip to content

Conversation

@chkr-private
Copy link
Contributor

This PR is related to issue #1455: starting pymodbus.simulator.

  • correct misplaced default value: 8081 applies to the http_port and not the http_host
  • makes the default path for setup.json independent of the current working directory

- default location for setup.json is the same directory as
  pymodbus/server/simulator/main.py
- this allows running pymodbus.simulator from toplevel of
  a git checkout as well as from an installed python package
  if setup.json is installed accordingly
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

@janiversen janiversen merged commit f815003 into pymodbus-dev:dev Mar 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants