Expand mypy config, following HomeAssistant

[alexrudd2]

Builds on #1388

See #1360

[janiversen]

Looks good. Hope the most parts can be done without tooo much editing.

[alexrudd2]

Looks good. Hope the most parts can be done without tooo much editing.

Enabling all the rules gives ~1000 errors, mostly disallow_untyped_defs. I think we should more cleanly define internal versus external methods, since external ones are more important to be typed correctly.

[janiversen]

That is a plan I highly agree with. As I work through the code, all real externals will be or are defined in init as external symbols, that can at least to identify the external interfaces.

Can e.g. "disallow_untyped_defs" be restricted to a module ? if so, we can consider making a API module, and have all external classes (pure interface classes there). That does not sound difficult to do, and will just affect the import statement in the apps.

[janiversen]

Once you update your branch (also in the other PRs) you will possibly see more problems.

[alexrudd2]

Can e.g. "disallow_untyped_defs" be restricted to a module ? if so, we can consider making a API module, and have all external classes (pure interface classes there). That does not sound difficult to do, and will just affect the import statement in the apps.

I believe so, yes.

[janiversen]

Then I suggest (but you decide):

• activate the options that are (relative) easy to solve
• keep the rest deactivated
• Group the ones you think we should activate for in a interface module
• Group the rest as unwanted
  I have done a similar thing in the pylint setup, and it helps me remember that an option was tried and discarded etc.

You do not need to do it all in this PR, just put it up for review when you want.

[janiversen]

and you have a couple of conflicts to solve...

[alexrudd2]

and you have a couple of conflicts to solve...

Yes, I am rebasing now locally

[janiversen]

Handler can be all 3 handlers, but I am ok with only typing one of them.

[janiversen]

LGTM.