Skip to content

Conversation

@banana-sun
Copy link
Contributor

The stress test: I used FUNC code 0x15 to transmit the file, tested it 30 times with different baud rates, and found no incomplete received frames.
RTU function unavailable: Compared with the modified file, in the original processing, we can see that the size has been modified in ModbusSerialClient/recv. This will lead to later check errors, resulting in RTU function unavailable. There is no log now. The source code check (pymodbus/transaction. py/ModbusTransactionManager/_recv) is attached.

            read_min = self.client.framer.recvPacket(min_size)
            if len(read_min) != min_size:
                msg_start = "Incomplete message" if read_min else "No response"
                raise InvalidMessageReceivedException(
                    f"{msg_start} received, expected at least {min_size} bytes "
                    f"({len(read_min)} received)"
                )

@janiversen
Copy link
Collaborator

you still have a formatting issue (black).

@banana-sun
Copy link
Contributor Author

I think running ./check_ci.sh requires some environment.
./check_ci.sh: line 8: codespell: command not found "codespell" command filed with exit code 127.

@janiversen
Copy link
Collaborator

Well it does expect you to read the README, and install requirements.txt, as this is needed for all development in this project.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@janiversen janiversen merged commit 8af46d8 into pymodbus-dev:dev Mar 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants