-
Notifications
You must be signed in to change notification settings - Fork 1k
serial sync recv interval #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serial sync recv interval #1389
Conversation
|
you still have a formatting issue (black). |
|
I think running ./check_ci.sh requires some environment. |
|
Well it does expect you to read the README, and install requirements.txt, as this is needed for all development in this project. |
janiversen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
The stress test: I used FUNC code 0x15 to transmit the file, tested it 30 times with different baud rates, and found no incomplete received frames.
RTU function unavailable: Compared with the modified file, in the original processing, we can see that the size has been modified in ModbusSerialClient/recv. This will lead to later check errors, resulting in RTU function unavailable. There is no log now. The source code check (pymodbus/transaction. py/ModbusTransactionManager/_recv) is attached.