Skip to content

Fix NoReponse -> NoResponse #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiversen merged 2 commits into from
Feb 19, 2023
Merged

Fix NoReponse -> NoResponse #1358

janiversen merged 2 commits into from
Feb 19, 2023

Conversation

@alexrudd2
Copy link
Collaborator

@alexrudd2 alexrudd2 commented Feb 19, 2023

While confused by type hinting, I found this typo. Leaving the 2.5.3 examples alone...

janiversen
janiversen approved these changes Feb 19, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janiversen janiversen merged commit 3cca43e into dev Feb 19, 2023
@janiversen janiversen deleted the reponse-typo branch February 19, 2023 07:47
alexrudd2 added a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
@alexrudd2
Fix NoReponse -> NoResponse (pymodbus-dev#1358)
bf67f13 
* Fix NoReponse -> NoResponse
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexrudd2 @janiversen