Update links to pydmodbus-dev #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrudd2
commented
Jan 24, 2023
Collaborator
|
Seems you have a lot of good changes here! let me just do the review. |
janiversen
approved these changes
Jan 24, 2023
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
Good catches!
you have done with lang=en, where my PR was only riptideio --> pymodbus-dev
janiversen
requested changes
Jan 24, 2023
janiversen
approved these changes
Jan 24, 2023
Collaborator
|
Thanks. |
alexrudd2
added a commit
to alexrudd2/pymodbus
that referenced
this pull request
Feb 21, 2023
Add HTML lang attribute, Update README.rst Co-authored-by: jan iversen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riptideio->pymodbus-dev. This fixes the install issue @aritakku was facingOriginally posted by @aritakku in #1290 (comment)