Skip to content

Fix type hints for port and timeout #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
Oct 28, 2022
Merged

Fix type hints for port and timeout #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pymodbus/client/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ModbusBaseClient(ModbusClientMixin):
**Parameters common to all clients**:

:param framer: (optional) Modbus Framer class.
:param timeout: (optional) Timeout for a request.
:param timeout: (optional) Timeout for a request, in seconds.
:param retries: (optional) Max number of retries pr request.
:param retry_on_empty: (optional) Retry on empty response.
:param close_comm_on_error: (optional) Close connection on error.
Expand Down Expand Up @@ -69,9 +69,9 @@ class _params: # pylint: disable=too-many-instance-attributes
"""Parameter class."""

host: str = None
port: str | float = None
port: str | int = None
framer: ModbusFramer = None
timeout: int = None
timeout: float = None
retries: int = None
retry_on_empty: bool = None
close_comm_on_error: bool = None
Expand Down