Skip to content

Obey timeout parameter on connection #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 3 commits into from
Oct 22, 2022
Merged

Obey timeout parameter on connection #1131

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
513468a
Obey timeout parameter on connection
alexrudd2 Oct 21, 2022
e943f69
Merge branch 'riptideio:dev' into patch-4
alexrudd2 Oct 21, 2022
1addde1
add timeouts to serial connections
alexrudd2 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pymodbus/client/tcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,11 @@ async def _connect(self):
"""Connect."""
_logger.debug("Connecting.")
try:
transport, protocol = await self.loop.create_connection(
self._create_protocol, host=self.params.host, port=self.params.port
transport, protocol = await asyncio.wait_for(
self.loop.create_connection(
self._create_protocol, host=self.params.host, port=self.params.port
),
timeout=self.params.timeout,
)
return transport, protocol
except Exception as exc: # pylint: disable=broad-except
Expand Down