async serial server isn't explicitly started by StartAsyncSerialServer #1280
Description
Now my python modbus server isn't replying to the client talking to it on the serial port. It was working with 3.1.0, it fails with 3.1.1, and it's not because of the logging changes. I'll investigate...
Meanwhile, found a typo:
tcp.py line 213:
if self.params.host.startswith("unit:"):
"unit" should be "unix", since it's about unix sockets...
===
I found the issue, it works now.
In 3.1.0, StartAsyncSerialServer() calls server.start()
In 3.1.1 it does not and returns the server object.
So I added .start() in my code on the return value of StartAsyncSerialServer(), and now the server serves.
I wonder if this is a bug in my code, perhaps I was supposed to call .start(), but it feels weird that a function called StartAsyncSerialServer() does not actually start the server. Hmm...
Originally posted by @peufeu2 in #1279 (comment)