Handle implicit broadcasting correctly in RandomVariable vectorization #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_rv_vectorization
branch
2 times, most recently
from
1765331 to
1d98fa7
Compare
ricardoV94
force-pushed
the
fix_rv_vectorization
branch
from
1d98fa7 to
700e0da
Compare
|
What's an example of a graph that is currently incorrectly vectorized? |
MWE in original issue and all new tests |
ricardoV94
force-pushed
the
fix_rv_vectorization
branch
from
700e0da to
909ad93
Compare
10 tasks
ricardoV94
force-pushed
the
fix_rv_vectorization
branch
from
909ad93 to
5915c98
Compare
ricardoV94
force-pushed
the
fix_rv_vectorization
branch
from
5915c98 to
2a0600a
Compare
|
Tests are passing |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change