Fix failing VI test due to pytest change #7144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7144 +/- ##
===========================================
+ Coverage 58.65% 92.25% +33.59%
===========================================
Files 101 101
Lines 16961 16961
===========================================
+ Hits 9949 15647 +5698
+ Misses 7012 1314 -5698 |
|
Many thanks investigating that! |
ricardoV94
requested changes
Feb 7, 2024
ricardoV94
reviewed
Feb 8, 2024
tests/variational/test_inference.py
Outdated
| pytest.skip(str(e)) | ||
|
|
||
| if expected_warning: | ||
| assert len(record) > 1 |
There was a problem hiding this comment.
Why is it bigger than 1 and not just bigger than zero?
There was a problem hiding this comment.
Ups, just my stupid mistake
ricardoV94
approved these changes
Feb 8, 2024
ricardoV94
changed the title
ricardoV94
added
tests
no releasenotes
|
Thanks a ton @aerubanov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pytest 7 missing warning were ignored if some exception was raised, but pytest 8 checking them and thats why
test_fit_start[SVGD-mini]fails. I replacedpytest.warn()by manual check for warning raised.Related Issue
Type of change
📚 Documentation preview 📚: https://pymc--7144.org.readthedocs.build/en/7144/