-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use numpy testing utilities instead of custom close_to* #6961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
- The previous identity_f function returned an empty array. This was missed by our check but captured by numpy.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6961 +/- ##
===========================================
- Coverage 89.01% 68.82% -20.20%
===========================================
Files 100 100
Lines 16859 16857 -2
===========================================
- Hits 15007 11601 -3406
- Misses 1852 5256 +3404 |
@ricardoV94 Any idea about what happened here? The measured code coverage has gone down by 20%. |
The codecov is stupid, it doesn't rerun after the first time, and if that failed that's what stays: #6660 No need to worry about it in your case |
Thanks a ton @erik-werner |
Closes #6748
What is this PR about?
This PR replaces our custom close_to* functions with numpy testing asserts with nice error displays and more careful array shape checking.
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6961.org.readthedocs.build/en/6961/