codecov coverage uploaded after tests succeed #6705
Conversation
michaelraczycki
changed the title
.github/workflows/tests.yml
Outdated
| merge-reports: | ||
| runs-on: ubuntu-latest | ||
| needs: [all_tests, changes] | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| - name: Merge coverage reports | ||
| run: | | ||
| # Activate conda environment | ||
| conda activate pymc-test | ||
| # Find all coverage reports and merge them into a single file | ||
| python -m coverage combine --append coverage-*.xml | ||
|
|
||
| - name: Save combined coverage report | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: coverage | ||
| path: coverage |
There was a problem hiding this comment.
Why do we need this extra job? PyTensor doesn't seem to have an equivalent one.
There was a problem hiding this comment.
pytensor has just one job ('test_ubuntu') that generates the codecov report. in pymc there are many more, that generate partial reports. Adding step that combines them into one final report after all report-generating jobs finish seemed like an easier task
There was a problem hiding this comment.
Okay, but it can still be done in a single job no? Just merge the two steps
There was a problem hiding this comment.
by two steps do you mean merge-reports and upload coverage?
There was a problem hiding this comment.
Yes, this way there's a bit less clutter in the PR checks
There was a problem hiding this comment.
sure, should be possible
What is this PR about?
Adaptations of tests.yaml requested in #6660
**Implementation details:
Removed partial codecov upload that was triggered after each subtest, instead added one that is made only In case of all tests passing
📚 Documentation preview 📚: https://pymc--6705.org.readthedocs.build/en/6705/