Skip to content

Conversation

@jhrcook
Copy link
Contributor

@jhrcook jhrcook commented May 14, 2022

The nuts_kwargs argument is currently missing from the docstring of sample_numpyro_nuts. This just adds a simple statement to indicate that the keyword arguments are passed to numpyro.infer.NUTS().

Thank your for opening a PR!

Before you proceed, please make sure that the pre-commit linting/style checks pass.

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
  • [ x important background, or details about the implementation
  • are the changes—especially new features—covered by tests and docstrings?
  • consider adding/updating relevant example notebooks
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

The `nuts_kwargs` argument is currently missing from the docstring of `sample_numpyro_nuts`. This just adds a simple statement to indicate that the keyword arguments are passed to `numpyro.infer.NUTS()`.
@canyon289
Copy link
Member

Thanks for the contribution!

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #5764 (416da76) into main (ab593b1) will decrease coverage by 3.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5764      +/-   ##
==========================================
- Coverage   89.27%   86.03%   -3.24%     
==========================================
  Files          74       74              
  Lines       13803    13803              
==========================================
- Hits        12322    11875     -447     
- Misses       1481     1928     +447     
Impacted Files Coverage Δ
pymc/sampling_jax.py 96.96% <ø> (ø)
pymc/step_methods/mlda.py 50.41% <0.00%> (-45.97%) ⬇️
pymc/step_methods/metropolis.py 50.21% <0.00%> (-32.77%) ⬇️
pymc/sampling.py 75.63% <0.00%> (-12.53%) ⬇️
pymc/step_methods/arraystep.py 86.52% <0.00%> (-6.39%) ⬇️
pymc/backends/report.py 86.56% <0.00%> (-4.48%) ⬇️
pymc/backends/base.py 85.71% <0.00%> (-1.47%) ⬇️
pymc/step_methods/slicer.py 94.36% <0.00%> (-1.41%) ⬇️

@canyon289 canyon289 merged commit 3b4da05 into pymc-devs:main May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants