Skip to content

Update pr_tutorial.md #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2022
Merged

Update pr_tutorial.md #5724

merged 2 commits into from
May 19, 2022

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Apr 23, 2022

Make the python version consistent on the PR tutorial, which seems to be py38.

Make the python version consistent on the PR tutorial.
@canyon289
Copy link
Member

I hesitate to change this to be a version number down. Where is the other source that is at 3.8? Can that be upversioned?

@canyon289 canyon289 closed this May 19, 2022
@canyon289 canyon289 reopened this May 19, 2022
@canyon289
Copy link
Member

Apologies closed by accident but question remains

@juanitorduz
Copy link
Contributor Author

juanitorduz commented May 19, 2022

Sorry for the lack of description. The conflict IMO is with line 48 (see below), where the python version is 3.8

image

@canyon289
Copy link
Member

Ah great catch. lets change the ones below then to go to python 3.9. What would that take?

@juanitorduz
Copy link
Contributor Author

Suggested change added in 9f5f7fc :)

@twiecki twiecki merged commit f0c8f55 into pymc-devs:main May 19, 2022
@juanitorduz juanitorduz deleted the patch-1 branch May 20, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants