Skip to content

Added moment for geometric distribution along with test for issue #5078 #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

sagartomar
Copy link
Contributor

@sagartomar sagartomar commented Nov 8, 2021

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

@sagartomar sagartomar mentioned this pull request Nov 8, 2021
51 tasks
@sagartomar sagartomar requested a review from ricardoV94 November 9, 2021 15:34
@ricardoV94
Copy link
Member

It seems like you picked some commits that are not part of your PR. You will probably need to rebase to fix it.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #5158 (1f20dd8) into main (35f9966) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5158      +/-   ##
==========================================
+ Coverage   78.05%   78.07%   +0.02%     
==========================================
  Files          88       88              
  Lines       14138    14142       +4     
==========================================
+ Hits        11035    11042       +7     
+ Misses       3103     3100       -3     
Impacted Files Coverage Δ
pymc/distributions/continuous.py 95.98% <100.00%> (-0.01%) ⬇️
pymc/distributions/discrete.py 99.41% <100.00%> (+<0.01%) ⬆️
pymc/backends/report.py 91.60% <0.00%> (+2.09%) ⬆️

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased your PR and added a couple of unrelated commits that I had in the backlog.

@ricardoV94 ricardoV94 merged commit 7745f55 into pymc-devs:main Nov 10, 2021
@ricardoV94
Copy link
Member

Thanks @sagartomar just merged the PR! Looking forward to your next one :)

@sagartomar
Copy link
Contributor Author

Thanks @ricardoV94

@sagartomar sagartomar deleted the dist_moments branch November 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants