Skip to content

Condition xfails on Windows after bug fix affected linux only #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

michaelosthege
Copy link
Member

A fix for aesara-devs/aesara#390 was rolled out with Aesara 2.1.3 but apparently it did not fix the problem on Windows.

The pipeline on main started failing right after the release, while the commits on PyMC3 main were just typo fixes:
grafik

Unfortunately I don't have much time to spare, so this PR just limits the scope of the XFAIL marks to make the CI pass again.

CC @brandonwillard in case you have an idea while the issue may still persist.

A fix for Aesara issue 390 was rolled out with Aesara 2.1.3 but apparently it did not fix the problem on Windows.
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #4902 (e41d0ef) into main (523d869) will increase coverage by 10.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4902       +/-   ##
===========================================
+ Coverage   62.39%   73.16%   +10.77%     
===========================================
  Files          86       86               
  Lines       13838    13838               
===========================================
+ Hits         8634    10125     +1491     
+ Misses       5204     3713     -1491     
Impacted Files Coverage Δ
pymc3/parallel_sampling.py 87.20% <0.00%> (-1.02%) ⬇️
pymc3/distributions/continuous.py 96.26% <0.00%> (+0.24%) ⬆️
pymc3/backends/base.py 86.15% <0.00%> (+0.76%) ⬆️
pymc3/step_methods/hmc/base_hmc.py 91.05% <0.00%> (+1.62%) ⬆️
pymc3/data.py 81.33% <0.00%> (+1.77%) ⬆️
pymc3/blocking.py 97.56% <0.00%> (+2.43%) ⬆️
pymc3/util.py 73.50% <0.00%> (+2.64%) ⬆️
pymc3/step_methods/slicer.py 95.65% <0.00%> (+2.89%) ⬆️
pymc3/step_methods/hmc/nuts.py 97.50% <0.00%> (+3.12%) ⬆️
pymc3/model_graph.py 84.78% <0.00%> (+3.62%) ⬆️
... and 23 more

@canyon289 canyon289 closed this Aug 4, 2021
@canyon289 canyon289 reopened this Aug 4, 2021
@canyon289
Copy link
Member

Sorry closed by accident. Reopened

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an open issue to track this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pytensor tests winOS windows OS related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants