Fix false positive for inherit-non-class for generic Protocols
#9108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9108 +/- ##
=======================================
Coverage 95.75% 95.76%
=======================================
Files 173 173
Lines 18663 18663
=======================================
+ Hits 17871 17872 +1
+ Misses 792 791 -1
|
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit ab1a8be |
Pierre-Sassoulas
approved these changes
Oct 4, 2023
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Oct 4, 2023
…9108) (#9111) (cherry picked from commit cd4b292) Co-authored-by: Daniël van Noord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9106.
Thought I would make a PR, has been a while 😄
Fixes a false positive which is apparently a regression in
3.x.