Skip to content

Work on documentation for non-ascii-file-name #8324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Work on documentation for non-ascii-file-name #8324

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8f806e2
Adding non-ascii-file-name to deletedMessages
ollie-iterators Feb 21, 2023
aa20dea
Merge remote-tracking branch 'upstream/main' into documentationTen
ollie-iterators Feb 21, 2023
4582c4a
Adding changelog
ollie-iterators Feb 21, 2023
308ff7f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 21, 2023
b78a610
Removed documentation for non-ascii-file-name
ollie-iterators Feb 22, 2023
54c76d5
Changed name of fragment
ollie-iterators Feb 22, 2023
9505455
Add version guard to non-ascii-file-name
ollie-iterators Feb 22, 2023
ebdb7a4
Revert "Removed documentation for non-ascii-file-name"
ollie-iterators Feb 22, 2023
d586e4b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 22, 2023
91b5b71
Reverted other changes to the code
ollie-iterators Feb 22, 2023
e57ee78
Merge branch 'documentationTen' of https://github.com/ollie-iterators…
ollie-iterators Feb 22, 2023
49aefe6
Add more links to description
ollie-iterators Feb 22, 2023
b840b8e
Reverting code
ollie-iterators Feb 23, 2023
9feb318
Changing code
ollie-iterators Feb 23, 2023
9165188
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 23, 2023
9ee4f49
Merge remote-tracking branch 'upstream/main' into documentationTen
ollie-iterators Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/data/messages/n/non-ascii-file-name/good.py
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions doc/data/messages/n/non-ascii-file-name/pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[main]
py-version = 3.4
4 changes: 3 additions & 1 deletion doc/user_guide/checkers/features.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,9 @@ Nonascii-Checker checker Messages
interoperability. Further reading: -
https://peps.python.org/pep-0489/#export-hook-name -
https://peps.python.org/pep-0672/#confusing-features -
https://bugs.python.org/issue20485
https://bugs.python.org/issue20485 -
https://github.com/python/cpython/issues/64684#issuecomment-1093644763 -
https://terpconnect.umd.edu/~zben/Web/CharSet/htmlchars.html
:non-ascii-name (C2401): *%s name "%s" contains a non-ASCII character, consider renaming it.*
Used when the name contains at least one non-ASCII unicode character. See
https://peps.python.org/pep-0672/#confusing-features for a background why
Expand Down
2 changes: 2 additions & 0 deletions pylint/checkers/non_ascii_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ class NonAsciiNameChecker(base_checker.BaseChecker):
"- https://peps.python.org/pep-0489/#export-hook-name\n"
"- https://peps.python.org/pep-0672/#confusing-features\n"
"- https://bugs.python.org/issue20485"
"- https://github.com/python/cpython/issues/64684#issuecomment-1093644763"
"- https://terpconnect.umd.edu/~zben/Web/CharSet/htmlchars.html"
),
),
# First %s will always be "module"
Expand Down