Skip to content

create TERMINATING_FUNCS_QNAMES #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022
Merged

create TERMINATING_FUNCS_QNAMES #7825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pylint/checkers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@

SINGLETON_VALUES = {True, False, None}

TERMINATING_FUNCS_QNAMES = frozenset(
{"_sitebuiltins.Quitter", "sys.exit", "posix._exit", "nt._exit"}
)


class NoSuchArgumentError(Exception):
pass
Expand Down Expand Up @@ -2149,11 +2153,12 @@ def is_terminating_func(node: nodes.Call) -> bool:
):
return False

qnames = {"_sitebuiltins.Quitter", "sys.exit", "posix._exit", "nt._exit"}

try:
for inferred in node.func.infer():
if hasattr(inferred, "qname") and inferred.qname() in qnames:
if (
hasattr(inferred, "qname")
and inferred.qname() in TERMINATING_FUNCS_QNAMES
):
return True
except (StopIteration, astroid.InferenceError):
pass
Expand Down