Refactor _collect_block_lines
#6560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
Pull Request Test Coverage Report for Build 2294120969
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
May 9, 2022
| """Set the state of a message in a block of lines.""" | ||
| first = node.fromlineno | ||
| last = node.tolineno | ||
| for lineno, state in list(lines.items()): |
There was a problem hiding this comment.
Is the call to list necessary ?
There was a problem hiding this comment.
That would be a nice lint warning 😄
There was a problem hiding this comment.
Ah, it necessary...
There was a problem hiding this comment.
It looked like an artifact from a 2to3 migration, my bad :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Ref. #6556.
Main difference is that we now get the message definitions before calling/doing
_set_message_state_in_block. It's a little cleaner and separates some functionality._collect_block_linesbecomes a bit pointless though.