Skip to content

Fix disabling of bad-option-value #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented May 9, 2022

  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🐛 Bug fix

Description

Closes #3312.

@DanielNoord DanielNoord force-pushed the bad-option-value-4 branch from c0da506 to 51a3a40 Compare May 9, 2022 13:10
@DanielNoord DanielNoord added Bug 🪲 Enhancement ✨ Improvement to a component Configuration Related to configuration labels May 9, 2022
@DanielNoord DanielNoord force-pushed the bad-option-value-4 branch from 51a3a40 to 58a018e Compare May 9, 2022 14:27
@DanielNoord DanielNoord force-pushed the bad-option-value-4 branch from 58a018e to b597461 Compare May 9, 2022 14:48
@DanielNoord DanielNoord added this to the 2.14.0 milestone May 9, 2022
@DanielNoord DanielNoord marked this pull request as ready for review May 9, 2022 15:06
@coveralls
Copy link

coveralls commented May 9, 2022

Pull Request Test Coverage Report for Build 2296660856

  • 14 of 16 (87.5%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/utils/file_state.py 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
pylint/utils/file_state.py 3 95.24%
Totals Coverage Status
Change from base Build 2294729067: -0.03%
Covered Lines: 16018
Relevant Lines: 16805

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylint 3.0 will be SO clean :)

Co-authored-by: Pierre Sassoulas <[email protected]>
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DanielNoord amazing work !

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. This really adds value to the beta.

I might track in a follow up issue (nothing blocking us now!) to allow --disable=all to disable the messages emitted for a .pylintrc, as it's a little unexpected to not be able to use that:

% pylint music21 --disable=all 
************* Module /Users/.../music21/.pylintrc
.pylintrc:1:0: E0012: Bad option value for --disable. Don't recognize message bad-whitespace. (bad-option-value)
.pylintrc:1:0: E0012: Bad option value for --disable. Don't recognize message bad-continuation. (bad-option-value)
.pylintrc:1:0: E0012: Bad option value for --disable. Don't recognize message no-self-use. (bad-option-value)
.pylintrc:1:0: E0012: Bad option value for --disable. Don't recognize message star-args. (bad-option-value)
************* Module /Users/.../music21/.pylintrc
.pylintrc:1:0: E0015: Unrecognized option found: profile, files-output, bad-functions, function-name-hint, variable-name-hint, const-name-hint, attr-name-hint, argument-name-hint, class-attribute-name-hint, inlinevar-name-hint, class-name-hint, module-name-hint, method-name-hint, no-space-check (unrecognized-option)

@DanielNoord DanielNoord merged commit afa6853 into pylint-dev:main May 9, 2022
@DanielNoord DanielNoord deleted the bad-option-value-4 branch May 10, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 C: Pragma's Configuration Related to configuration Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't disable bad-option-value
4 participants