Skip to content

Add example for use-maxsplit-arg message documentation #6232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add example for use-maxsplit-arg message documentation #6232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/data/messages/u/use-maxsplit-arg/bad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
url = "www.example.com"
suffix = url.split(".")[-1] # [use-maxsplit-arg]
3 changes: 3 additions & 0 deletions doc/data/messages/u/use-maxsplit-arg/details.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Be aware that the performance improvement from not splitting the string
so many times will only be realized in cases presenting more instances of
the splitting character than the minimal example here.
2 changes: 2 additions & 0 deletions doc/data/messages/u/use-maxsplit-arg/good.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
url = "www.example.com"
suffix = url.rsplit(".", maxsplit=1)[-1]