Skip to content

Conversation

@gunungpw
Copy link
Contributor

@gunungpw gunungpw commented Apr 1, 2022

Co-authored-by: Vladyslav Krylasov [email protected]

  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

add code example for duplicate-bases
add python traceback error message
add Issue Tracker link

Ref #5953

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @gunungpw

gunungpw added 3 commits April 1, 2022 15:43
remove unreliable link
add `duplicate-bases` description
move error message to description in `class_checker.py`
@gunungpw
Copy link
Contributor Author

gunungpw commented Apr 1, 2022

Any advice why Checks / documentation (pull_request) fail? I am new to programing and Github 😄

@coveralls
Copy link

coveralls commented Apr 1, 2022

Pull Request Test Coverage Report for Build 2076268437

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.308%

Totals Coverage Status
Change from base Build 2072955906: 0.0%
Covered Lines: 15459
Relevant Lines: 16392

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Apr 1, 2022
@DanielNoord
Copy link
Collaborator

@gunungpw I'm scared it might be due to #6060.

If you want to fix it you would likely need to look for the add_message calls that have "duplicate-bases" as their first argument. Then figure it by which visit_... or leave_... method (I guess visit_classdef) they get called and check if duplicate-bases is in their check_messages decorator. I know that is quite a lot so if you have trouble figuring this out let me know and I can take a look myself!

@gunungpw
Copy link
Contributor Author

gunungpw commented Apr 1, 2022

@gunungpw I'm scared it might be due to #6060.

If you want to fix it you would likely need to look for the add_message calls that have "duplicate-bases" as their first argument. Then figure it by which visit_... or leave_... method (I guess visit_classdef) they get called and check if duplicate-bases is in their check_messages decorator. I know that is quite a lot so if you have trouble figuring this out let me know and I can take a look myself!

I learned a lot today, the issue may be a bit too complex for me.
Hope you have a nice day

@DanielNoord
Copy link
Collaborator

@gunungpw I'm scared it might be due to #6060.
If you want to fix it you would likely need to look for the add_message calls that have "duplicate-bases" as their first argument. Then figure it by which visit_... or leave_... method (I guess visit_classdef) they get called and check if duplicate-bases is in their check_messages decorator. I know that is quite a lot so if you have trouble figuring this out let me know and I can take a look myself!

I learned a lot today, the issue may be a bit too complex for me. Hope you have a nice day

@Pierre-Sassoulas Actually already fixed it by adding the comment. 😄

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @gunungpw , and congratulation on becoming a contributor !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 03a115e into pylint-dev:main Apr 1, 2022
@gunungpw gunungpw deleted the duplicate-bases branch April 3, 2022 03:50
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants