Skip to content

Examples for bad-exception-context #6026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Examples for bad-exception-context #6026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a9642
Examples for ``bad-exception-context``.
DudeNr33 Mar 29, 2022
29f5f9a
Apply suggestions from code review
DudeNr33 Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/data/messages/b/bad-exception-context/bad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError:
raise ValueError(f"Division by zero when dividing {x} by {y} !") from result # [bad-exception-context]
return result
Comment on lines +1 to +7
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError:
raise ValueError(f"Division by zero when dividing {x} by {y} !") from result # [bad-exception-context]
return result
class YParameterIsZero(ZeroDivisionError):
...
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError:
raise YParameterIsZero(f"Division by zero when dividing {x} by {y} !") from result # [bad-exception-context]
return result

7 changes: 7 additions & 0 deletions doc/data/messages/b/bad-exception-context/good.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError as exc:
raise ValueError(f"Division by zero when dividing {x} by {y} !") from exc
return result
Comment on lines +1 to +7
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError as exc:
raise ValueError(f"Division by zero when dividing {x} by {y} !") from exc
return result
class YParameterIsZero(ZeroDivisionError):
...
def divide(x, y):
result = 0
try:
result = x / y
except ZeroDivisionError as exc:
raise YParameterIsZero(f"Division by zero when dividing {x} by {y} !") from exc
return result

2 changes: 2 additions & 0 deletions doc/data/messages/b/bad-exception-context/related.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `The raise statement <https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement>`_
- `Explicit Exception Chaining <https://peps.python.org/pep-3134/#explicit-exception-chaining>`_ per PEP 3134