Skip to content

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

See #5509 (comment)

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 13, 2021
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe this is something to add to a TODO list for 2.14 ?

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Dec 13, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1572789916

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.655%

Totals Coverage Status
Change from base Build 1572737221: 0.01%
Covered Lines: 14185
Relevant Lines: 15146

πŸ’› - Coveralls

@DanielNoord DanielNoord mentioned this pull request Dec 13, 2021
15 tasks
@DanielNoord DanielNoord merged commit ee60bc1 into pylint-dev:main Dec 13, 2021
@DanielNoord DanielNoord deleted the follow-up-unittests branch December 13, 2021 12:41
@cdce8p
Copy link
Member

cdce8p commented Dec 13, 2021

I haven't followed the discussions around test functions, just an observation.
Even for test code, is a one release-cycle deprecation / removal appropriate?
(IMO it's okay to do in a minor release, but 2.14.0 seems a bit close.)

@DanielNoord
Copy link
Collaborator Author

I haven't followed the discussions around test functions, just an observation.

Even for test code, is a one release-cycle deprecation / removal appropriate?

(IMO it's okay to do in a minor release, but 2.14.0 seems a bit close.)

Since it was only added in 2.12.0 I think this might be okay. But I'll happily change this to 2.15/16 if you think that is better.

@cdce8p
Copy link
Member

cdce8p commented Dec 13, 2021

I don't really care about it tbh. Just wanted to point out that we should think a bit about deprecation periods in the future.

@DanielNoord DanielNoord mentioned this pull request Apr 2, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants