Fix crash when a variable annotation is used as if test expression
#10714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 9b67845 |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10714 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 176 176
Lines 19537 19539 +2
=======================================
+ Hits 18750 18752 +2
Misses 787 787
π New features to boost your workflow:
|
zenlyj
changed the title
consider-using-assignment-expr when a variable annotation without assignment is used as the if test expressionif test expression
zenlyj
changed the title
if test expressionif test expression
zenlyj
changed the title
if test expressionif test expression
DanielNoord
approved these changes
Nov 3, 2025
Pierre-Sassoulas
added
Crash π₯
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Just a question, LGTM otherwise.
Comment on lines
+275
to
+277
| # Should ignore variable annotation without assignment | ||
| if prev_sibling.value is None: | ||
| return |
Member
There was a problem hiding this comment.
Should it be directly in _check_prev_sibling_to_if_stmt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The
consider-using-assignment-exprcheck should ignore cases where a variable annotation statement is represented as anAnnAssignnode without an assigned value.Closes #10707