Fix false negative for deprecated-module when a __import__ method is used instead of import sentence
#10454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
main-debug-statement-importpdb-moy
branch
2 times, most recently
from
5e00cc3 to
a246d1a
Compare
Contributor
Author
|
@Pierre-Sassoulas What do you think? Regards! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10454 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 176 176
Lines 19140 19142 +2
=======================================
+ Hits 18352 18354 +2
Misses 788 788
🚀 New features to boost your workflow:
|
moylop260
force-pushed
the
main-debug-statement-importpdb-moy
branch
3 times, most recently
from
e994e91 to
e336aa5
Compare
moylop260
changed the title
deprecated-module when a __import__ method is used instead of import sentence
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
requested changes
Jul 11, 2025
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Look great, this is going in 4.0 :)
Pierre-Sassoulas
added
the
False Negative 🦋
… is used instead of `import` sentence.
Using the following python code style
```python
__import__("deprecated_module")
```
The deprecated-module is ignored since that it expects
```python
import deprecated_module
```
This change adds the posibility to process these kind of style too
This style is used from popular auto-code snippets:
- https://github.com/honza/vim-snippets/blob/f0a3184/snippets/python.snippets#L209
Fix pylint-dev#10453
moylop260
force-pushed
the
main-debug-statement-importpdb-moy
branch
from
e336aa5 to
b4dc60c
Compare
Contributor
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit b4dc60c |
Pierre-Sassoulas
approved these changes
Jul 13, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the following python code style
The deprecated-module is ignored since that it expects
This change adds the posibility to process these kind of style too
This style is used from popular auto-code snippets:
Type of Changes
Description
Closes #10453