Fix crash in catching-non-exception when something besides a class in except
#10232
+19
β1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10232 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 175 175
Lines 19058 19058
=======================================
Hits 18266 18266
Misses 792 792
π New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
added
backport maintenance/4.0.x
Crash π₯
jacobtylerwalls
changed the title
jacobtylerwalls
changed the title
catching-non-exception when something besides a class in except
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
force-pushed
the
fix/10106/AttributeError_lambda_no_attribute
branch
from
35f1846 to
4caec3a
Compare
jacobtylerwalls
approved these changes
Feb 15, 2025
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 4caec3a |
jacobtylerwalls
pushed a commit
that referenced
this pull request
Feb 15, 2025
β¦ except (#10232) (#10234) (cherry picked from commit 007a745) Co-authored-by: ChandanChainani <[email protected]>
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #10106